Re: [Qemu-devel] [PATCH v5 4/9] qemu-log: Improve the "exec" TB execution logging

[Richard Henderson]

On 02/05/2016 01:56 AM, Alex Bennée wrote:
> From: Peter Maydell<address@hidden>
>
> Improve the TB execution logging so that it is easier to identify
> what is happening from trace logs:
>   * move the "Trace" logging of executed TBs into cpu_tb_exec()
>     so that it is emitted if and only if we actually execute a TB,
>     and for consistency for the CPU state logging
>   * log when we link two TBs together via tb_add_jump()
>   * log when cpu_tb_exec() returns early from a chain of TBs
>
> The new style logging looks like this:
>
> Trace 0x7fb7cc822ca0 [ffffffc0000dce00]
> Linking TBs 0x7fb7cc822ca0 [ffffffc0000dce00] index 0 -> 0x7fb7cc823110 
> [ffffffc0000dce10]
> Trace 0x7fb7cc823110 [ffffffc0000dce10]
> Trace 0x7fb7cc823420 [ffffffc000302688]
> Trace 0x7fb7cc8234a0 [ffffffc000302698]
> Trace 0x7fb7cc823520 [ffffffc0003026a4]
> Trace 0x7fb7cc823560 [ffffffc0000dce44]
> Linking TBs 0x7fb7cc823560 [ffffffc0000dce44] index 1 -> 0x7fb7cc8235d0 
> [ffffffc0000dce70]
> Trace 0x7fb7cc8235d0 [ffffffc0000dce70]
> Abandoned execution of TB chain before 0x7fb7cc8235d0 [ffffffc0000dce70]
> Trace 0x7fb7cc8235d0 [ffffffc0000dce70]
> Trace 0x7fb7cc822fd0 [ffffffc0000dd52c]
>
> Signed-off-by: Peter Maydell<address@hidden>
> Signed-off-by: Alex Bennée<address@hidden>
> [AJB: reword patch title]
> Reviewed-by: Aurelien Jarno<address@hidden>
> ---
>   cpu-exec.c              | 20 +++++++++++---------
>   include/exec/exec-all.h |  3 +++
>   2 files changed, 14 insertions(+), 9 deletions(-)

Looks good, though I quibble over the term "Abandoned".  To me that implies 
that nothing got executed, which isn't true.  I'd prefer "Stopped" or "Exited".

Otherwise,

Reviewed-by: Richard Henderson  <address@hidden>


r~