Re: [Qemu-devel] [PATCH 2/2] tests: Clean up includes

[Peter Maydell]

On 8 February 2016 at 20:51, Eric Blake <address@hidden> wrote:
> On 02/08/2016 11:49 AM, Peter Maydell wrote:
>
>>  122 files changed, 122 insertions(+), 202 deletions(-)
>
> You may want to wait for other maintainers to chime in for files they
> care about; but I looked through the patch and nothing jumped out at me
> as being incorrect.  Many of the files already includes libqtest.c or
> even osdep.h - for those files, the change is obviously correct.
>
> Reviewed-by: Eric Blake <address@hidden>
> Tested-by: Eric Blake <address@hidden>
>
>> +++ b/tests/multiboot/libc.c
>> @@ -20,6 +20,7 @@
>>   * THE SOFTWARE.
>>   */
>>
>> +#include "qemu/osdep.h"
>>  #include "libc.h"
>>
>>  void* memcpy(void *dest, const void *src, int n)
>
> Not so sure about this directory.

Good catch, will drop.

thanks
-- PMM