[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 02/17] chardev: Shorten references into ChardevB
From: |
Daniel P. Berrange |
Subject: |
Re: [Qemu-devel] [PATCH 02/17] chardev: Shorten references into ChardevBackend |
Date: |
Mon, 22 Feb 2016 10:16:10 +0000 |
User-agent: |
Mutt/1.5.24 (2015-08-30) |
On Fri, Feb 19, 2016 at 05:19:32PM -0700, Eric Blake wrote:
> An upcoming patch will alter how simple unions, like ChardevBackend,
> are laid out, which will impact all lines of the form 'backend->u.XXX'.
> To minimize the impact of that patch, use a temporary variable to
> reduce the number of lines needing modification when an internal
> reference within ChardevBackend changes layout.
>
> Signed-off-by: Eric Blake <address@hidden>
> ---
> qemu-char.c | 122
> ++++++++++++++++++++++++++++++++----------------------------
> 1 file changed, 66 insertions(+), 56 deletions(-)
Reviewed-By: Daniel P. Berrange <address@hidden>
Regards,
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|
- [Qemu-devel] [PATCH 00/17] qapi implicit types (continuing the qapi cleanup theme), Eric Blake, 2016/02/19
- [Qemu-devel] [PATCH 06/17] chardev: Drop useless ChardevDummy type, Eric Blake, 2016/02/19
- [Qemu-devel] [PATCH 07/17] qapi: Drop useless 'data' member of unions, Eric Blake, 2016/02/19
- [Qemu-devel] [PATCH 02/17] chardev: Shorten references into ChardevBackend, Eric Blake, 2016/02/19
- Re: [Qemu-devel] [PATCH 02/17] chardev: Shorten references into ChardevBackend,
Daniel P. Berrange <=
- [Qemu-devel] [PATCH 08/17] qapi-visit: Factor out gen_visit_fields_call(), Eric Blake, 2016/02/19
- [Qemu-devel] [PATCH 10/17] qapi: Fix command with named empty argument type, Eric Blake, 2016/02/19
- [Qemu-devel] [PATCH 09/17] qapi: Add type.is_empty() helper, Eric Blake, 2016/02/19
- [Qemu-devel] [PATCH 15/17] qapi: Use anonymous base in SchemaInfo, Eric Blake, 2016/02/19
- [Qemu-devel] [PATCH 13/17] qapi-visit: Move error check into gen_visit_fields_call(), Eric Blake, 2016/02/19
- [Qemu-devel] [PATCH 16/17] qapi: Use anonymous base in CpuInfo, Eric Blake, 2016/02/19
- [Qemu-devel] [PATCH 01/17] chardev: Properly initialize ChardevCommon components, Eric Blake, 2016/02/19
- [Qemu-devel] [PATCH 11/17] qapi-visit: Simplify visit of empty branch in union, Eric Blake, 2016/02/19