Re: [Qemu-devel] [PATCH 02/13] pci: Introduce define for PM capability version 1.1

[Leonid Bloch]

Dear Michael,

Thanks very much for your review! Please see comments inline.

Best regards,
Leonid.

On Thu, Feb 18, 2016 at 12:27 PM, Michael S. Tsirkin <address@hidden> wrote:
> On Thu, Feb 18, 2016 at 12:07:23PM +0200, Leonid Bloch wrote:
>> From: Dmitry Fleytman <address@hidden>
>>
>> Signed-off-by: Dmitry Fleytman <address@hidden>
>> Signed-off-by: Leonid Bloch <address@hidden>
>
> Sorry no - these are standard headers.
> You could add it in include/hw/pci/pci_regs.h

OK, added to include/hw/pci/pci_regs.h in v2.

> but I'm not sure it's worth it since there's
> a single user ...
> Maybe just use a number and add a comment where it's used.
>
>> ---
>>  include/standard-headers/linux/pci_regs.h | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/include/standard-headers/linux/pci_regs.h 
>> b/include/standard-headers/linux/pci_regs.h
>> index 1becea8..cfb5db2 100644
>> --- a/include/standard-headers/linux/pci_regs.h
>> +++ b/include/standard-headers/linux/pci_regs.h
>> @@ -226,6 +226,7 @@
>>
>>  #define PCI_PM_PMC           2       /* PM Capabilities Register */
>>  #define  PCI_PM_CAP_VER_MASK 0x0007  /* Version */
>> +#define  PCI_PM_CAP_VER_1_1     0x0002  /* PCI PM spec ver. 1.1 */
>>  #define  PCI_PM_CAP_PME_CLOCK        0x0008  /* PME clock required */
>>  #define  PCI_PM_CAP_RESERVED    0x0010  /* Reserved field */
>>  #define  PCI_PM_CAP_DSI              0x0020  /* Device specific 
>> initialization */
>> --
>> 2.5.0