Re: [Qemu-devel] [PATCH] log: do not log if QEMU is daemonized but without -D

[Cornelia Huck]

On Tue,  1 Mar 2016 12:50:53 +0100
Paolo Bonzini <address@hidden> wrote:

> Commit 96c33a4 ("log: Redirect stderr to logfile if deamonized",
> 2016-02-22) wanted to move stderr of a daemonized QEMU to the file
> specified with -D.
> 
> However, if -D was not passed, the patch had the side effect of not
> redirecting stderr to /dev/null.  This happened because qemu_logfile
> was set to stderr rather than the expected value of NULL.  The fix
> is simply in the "if" condition of do_qemu_set_log; the "if" for
> closing the file is also changed to match.
> 
> Reported-by: Jan Tomko <address@hidden>
> Signed-off-by: Paolo Bonzini <address@hidden>
> ---
>  util/log.c | 7 +++++--
>  1 file changed, 5 insertions(+), 2 deletions(-)

This fixes running qemu under libvirt for me.

Tested-by: Cornelia Huck <address@hidden>