[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] log: do not log if QEMU is daemonized but witho
|
From: |
Gerd Hoffmann |
|
Subject: |
Re: [Qemu-devel] [PATCH] log: do not log if QEMU is daemonized but without -D |
|
Date: |
Tue, 01 Mar 2016 14:51:34 +0100 |
On Di, 2016-03-01 at 12:50 +0100, Paolo Bonzini wrote:
> Commit 96c33a4 ("log: Redirect stderr to logfile if deamonized",
> 2016-02-22) wanted to move stderr of a daemonized QEMU to the file
> specified with -D.
>
> However, if -D was not passed, the patch had the side effect of not
> redirecting stderr to /dev/null. This happened because qemu_logfile
> was set to stderr rather than the expected value of NULL. The fix
> is simply in the "if" condition of do_qemu_set_log; the "if" for
> closing the file is also changed to match.
Tested-by: Gerd Hoffmann <address@hidden>
cheers,
Gerd