Re: [Qemu-devel] [PATCH 30/38] ivshmem: Simplify memory regions for BAR 2 (shared memory)

[Markus Armbruster]

Paolo Bonzini <address@hidden> writes:

> On 29/02/2016 19:40, Markus Armbruster wrote:
>> ivshmem_realize() puts the shared memory region in a container region.
>> Used to be necessary to permit delayed mapping of the shared memory.
>> Now we don't do that anymore, the container is redundant.  Drop it.
>
> Can you explain why we don't do that anymore to someone who hasn't read
> patches 4 to 28? :-)  Is it patch 23?

Yes, but you also need 24 to complete the job.

Commit message could perhaps explain it like this:

    ivshmem_realize() puts the shared memory region in a container
    region.  Used to be necessary to permit delayed mapping of the
    shared memory.  However, we recently moved to synchronous mapping,
    in "ivshmem: Receive shared memory synchronously in realize()" and
    the commit following it.  The container is redundant since then.
    Drop it.

Better?