[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 30/38] ivshmem: Simplify memory regions for BAR
|
From: |
Paolo Bonzini |
|
Subject: |
Re: [Qemu-devel] [PATCH 30/38] ivshmem: Simplify memory regions for BAR 2 (shared memory) |
|
Date: |
Tue, 1 Mar 2016 13:17:49 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.0 |
On 01/03/2016 13:14, Markus Armbruster wrote:
>> > Can you explain why we don't do that anymore to someone who hasn't read
>> > patches 4 to 28? :-) Is it patch 23?
> Yes, but you also need 24 to complete the job.
>
> Commit message could perhaps explain it like this:
>
> ivshmem_realize() puts the shared memory region in a container
> region. Used to be necessary to permit delayed mapping of the
> shared memory. However, we recently moved to synchronous mapping,
> in "ivshmem: Receive shared memory synchronously in realize()" and
> the commit following it. The container is redundant since then.
> Drop it.
>
> Better?
Yes, thanks!
Paolo