Re: [Qemu-devel] [PATCH 1/3] arm: gic: add GICType

[Eric Blake]

On 02/23/2016 03:52 AM, Peter Xu wrote:
> A new enum type is added to define ARM GIC types.
> 
> Signed-off-by: Peter Xu <address@hidden>
> ---
>  qapi-schema.json | 17 +++++++++++++++++
>  1 file changed, 17 insertions(+)
> 
> diff --git a/qapi-schema.json b/qapi-schema.json
> index 8d04897..81654bd 100644
> --- a/qapi-schema.json
> +++ b/qapi-schema.json
> @@ -4083,3 +4083,20 @@
>  ##
>  { 'enum': 'ReplayMode',
>    'data': [ 'none', 'record', 'play' ] }
> +
> +##
> +# @GICType:
> +#
> +# An enumeration of GIC types

Worth spelling out the acronym?

> +#
> +# @gicv2:     GICv2 support without kernel irqchip
> +#
> +# @gicv3:     GICv3 support without kernel irqchip
> +#
> +# @gicv2-kvm: GICv3 support with kernel irqchip

Doc typo, should be GICv2

> +#
> +# @gicv3-kvm: GICv3 support with kernel irqchip
> +#
> +# Since: 2.6
> +##
> +{ 'enum': 'GICType', 'data': [ 'gicv2', 'gicv3', 'gicv2-kvm', 'gicv3-kvm' ] }
> 

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

signature.asc
Description: OpenPGP digital signature