Re: [Qemu-devel] [PATCH 1/3] arm: gic: add GICType

[Peter Xu]

On Tue, Mar 01, 2016 at 09:46:07AM -0700, Eric Blake wrote:
> On 02/23/2016 03:52 AM, Peter Xu wrote:
> > A new enum type is added to define ARM GIC types.
> > 
> > Signed-off-by: Peter Xu <address@hidden>
> > ---
> >  qapi-schema.json | 17 +++++++++++++++++
> >  1 file changed, 17 insertions(+)
> > 
> > diff --git a/qapi-schema.json b/qapi-schema.json
> > index 8d04897..81654bd 100644
> > --- a/qapi-schema.json
> > +++ b/qapi-schema.json
> > @@ -4083,3 +4083,20 @@
> >  ##
> >  { 'enum': 'ReplayMode',
> >    'data': [ 'none', 'record', 'play' ] }
> > +
> > +##
> > +# @GICType:
> > +#
> > +# An enumeration of GIC types
> 
> Worth spelling out the acronym?

Sure. I can do it in next spin. 

> 
> > +#
> > +# @gicv2:     GICv2 support without kernel irqchip
> > +#
> > +# @gicv3:     GICv3 support without kernel irqchip
> > +#
> > +# @gicv2-kvm: GICv3 support with kernel irqchip
> 
> Doc typo, should be GICv2

Will fix. If dict to be used finally, will rework as a whole.

Thanks!
Peter