[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 13/38] ivshmem: Don't destroy the chardev on ver
|
From: |
Markus Armbruster |
|
Subject: |
Re: [Qemu-devel] [PATCH 13/38] ivshmem: Don't destroy the chardev on version mismatch |
|
Date: |
Wed, 02 Mar 2016 10:52:33 +0100 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) |
Marc-André Lureau <address@hidden> writes:
> Hi
>
> On Mon, Feb 29, 2016 at 7:40 PM, Markus Armbruster <address@hidden> wrote:
>> Yes, the chardev is commonly useless after we read a bad version from
>> it, but destroying it is inappropriate anyway: the user created it, so
>> the user should be able to hold on to it as long as he likes. We
>> don't destroy it on other errors. Screwed up in commit 5105b1d.
>>
>> Stop reading instead.
>>
>> Also note QEMU's behavior in ivshmem-spec.txt.
>>
>> Signed-off-by: Markus Armbruster <address@hidden>
>
> Interestingly enough, it seems both smartcard "passthru" and usb
> redirect do chr_delete(). It would a nice follow up to standardize
> this there too.
Wasn't aware of them. I'll see what I can do.
> Reviewed-by: Marc-André Lureau <address@hidden>
Thanks!