[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 11/19] qapi: Add type.is_empty() helper
|
From: |
Eric Blake |
|
Subject: |
Re: [Qemu-devel] [PATCH v2 11/19] qapi: Add type.is_empty() helper |
|
Date: |
Wed, 2 Mar 2016 16:04:15 -0700 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 |
On 03/02/2016 12:04 PM, Markus Armbruster wrote:
> Eric Blake <address@hidden> writes:
>
>> And use it in qapi-types and qapi-event. Down the road, we may
>> want to lift our artificial restriction of no variants at the
>> top level of an event, at which point, inlining our check for
>> whether members is empty will no longer be sufficient, but
>> adding a check for variants adds verbosity; in the meantime,
>> add some asserts in places where we don't handle variants.
>
> Perhaps I'm just running out of steam for today, but I've read this
> twice, and still don't get why adding these assertions goes in the same
> patch as adding the helper, or what it has to do with events.
Okay, will split this into two patches for v3.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature