[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 04/15] target-i386: do not pass MSR_TSC_AUX to KVM io
From: |
Paolo Bonzini |
Subject: |
[Qemu-devel] [PULL 04/15] target-i386: do not pass MSR_TSC_AUX to KVM ioctls if CPUID bit is not set |
Date: |
Tue, 5 Apr 2016 11:50:07 +0200 |
KVM does not let you read or write this MSR if the corresponding CPUID
bit is not set. This in turn causes MSRs that come after MSR_TSC_AUX
to be ignored by KVM_SET_MSRS.
One visible symptom is that s3.flat from kvm-unit-tests fails with
CPUs that do not have RDTSCP, because the SMBASE is not reset to
0x30000 after reset.
Fixes: c9b8f6b6210847b4381c5b2ee172b1c7eb9985d6
Cc: address@hidden
Signed-off-by: Paolo Bonzini <address@hidden>
---
target-i386/kvm.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/target-i386/kvm.c b/target-i386/kvm.c
index 87ab969..19e2d94 100644
--- a/target-i386/kvm.c
+++ b/target-i386/kvm.c
@@ -917,6 +917,9 @@ int kvm_arch_init_vcpu(CPUState *cs)
if (env->features[FEAT_1_EDX] & CPUID_MTRR) {
has_msr_mtrr = true;
}
+ if (!(env->features[FEAT_8000_0001_EDX] & CPUID_EXT2_RDTSCP)) {
+ has_msr_tsc_aux = false;
+ }
return 0;
}
--
2.5.5
- [Qemu-devel] [PULL 00/15] Misc changes for QEMU 2.6.0-rc1, Paolo Bonzini, 2016/04/05
- [Qemu-devel] [PULL 04/15] target-i386: do not pass MSR_TSC_AUX to KVM ioctls if CPUID bit is not set,
Paolo Bonzini <=
- [Qemu-devel] [PULL 02/15] target-i386/kvm: Hyper-V VMBus hypercalls blank handlers, Paolo Bonzini, 2016/04/05
- [Qemu-devel] [PULL 03/15] memory: fix segv on qemu_ram_free(block=0x0), Paolo Bonzini, 2016/04/05
- [Qemu-devel] [PULL 01/15] update Linux headers to 4.6, Paolo Bonzini, 2016/04/05
- [Qemu-devel] [PULL 05/15] target-i386: assert that KVM_GET/SET_MSRS can set all requested MSRs, Paolo Bonzini, 2016/04/05
- [Qemu-devel] [PULL 09/15] char: ensure all clients are in non-blocking mode, Paolo Bonzini, 2016/04/05
- [Qemu-devel] [PULL 08/15] char: fix broken EAGAIN retry on OS-X due to errno clobbering, Paolo Bonzini, 2016/04/05
- [Qemu-devel] [PULL 10/15] doc/memory: update MMIO section, Paolo Bonzini, 2016/04/05
- [Qemu-devel] [PULL 07/15] util: retry getaddrinfo if getting EAI_BADFLAGS with AI_V4MAPPED, Paolo Bonzini, 2016/04/05