Re: [Qemu-devel] [PATCH v3 1/2] target-i386: KVM: add basic Intel LMCE support

[Boris Petkov]

Haozhong Zhang <address@hidden> wrote:

>This patch adds the support to inject SRAR and SRAO as LMCE, i.e. they
>will be injected to only one VCPU rather than broadcast to all
>VCPUs. As KVM reports LMCE support on Intel platforms, this features is
>only available on Intel platforms.
>
>Signed-off-by: Ashok Raj <address@hidden>
>Signed-off-by: Haozhong Zhang <address@hidden>
>---
>Cc: Paolo Bonzini <address@hidden>
>Cc: Richard Henderson <address@hidden>
>Cc: Eduardo Habkost <address@hidden>
>Cc: Marcelo Tosatti <address@hidden>
>Cc: Boris Petkov <address@hidden>
>Cc: address@hidden
>Cc: Tony Luck <address@hidden>
>Cc: Andi Kleen <address@hidden>
>---
> target-i386/cpu.c | 26 ++++++++++++++++++++++++++
> target-i386/cpu.h | 13 ++++++++++++-
> target-i386/kvm.c | 35 +++++++++++++++++++++++++++++++----
> 3 files changed, 69 insertions(+), 5 deletions(-)

...

>@@ -1173,6 +1182,8 @@ struct X86CPU {
>      */
>     bool enable_pmu;
> 
>+    bool enable_lmce;

That struct would go fat pretty fast if it grows a bool per CPU feature. 
Perhaps a more clever, a-bit-per-featurebit scheme would be in order.

-- 
Sent from a small device: formatting sux and brevity is inevitable.