[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 1/2] target-i386: KVM: add basic Intel LMCE s
From: |
Eduardo Habkost |
Subject: |
Re: [Qemu-devel] [PATCH v3 1/2] target-i386: KVM: add basic Intel LMCE support |
Date: |
Tue, 7 Jun 2016 17:10:01 -0300 |
User-agent: |
Mutt/1.6.1 (2016-04-27) |
On Fri, Jun 03, 2016 at 02:09:43PM +0800, Haozhong Zhang wrote:
[...]
> +
> + if (cpu->enable_lmce) {
> + if (lmce_supported()) {
> + cenv->mcg_cap |= MCG_LMCE_P;
> + cenv->msr_ia32_feature_control |=
> + MSR_IA32_FEATURE_CONTROL_LMCE |
> + MSR_IA32_FEATURE_CONTROL_LOCKED;
> + } else {
> + error_report("Warning: KVM unavailable or not support LMCE, "
> + "LMCE disabled");
> + cpu->enable_lmce = false;
Please don't do that. If the user explicitly asked for LMCE, you
should refuse to start if the host doesn't have the required
capabilities.
> + }
> + }
> +
> cenv->mcg_ctl = ~(uint64_t)0;
> for (bank = 0; bank < MCE_BANKS_DEF; bank++) {
> cenv->mce_banks[bank * 4] = ~(uint64_t)0;
[...]
--
Eduardo
Re: [Qemu-devel] [PATCH v3 1/2] target-i386: KVM: add basic Intel LMCE support,
Eduardo Habkost <=
[Qemu-devel] [PATCH v3 2/2] target-i386: add migration support for Intel LMCE, Haozhong Zhang, 2016/06/03
Re: [Qemu-devel] [PATCH v3 0/2] Add QEMU support for Intel local MCE, Haozhong Zhang, 2016/06/03