[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH] block: Fix bdrv_all_delete_snapshot() error handlin
From: |
Kevin Wolf |
Subject: |
[Qemu-devel] [PATCH] block: Fix bdrv_all_delete_snapshot() error handling |
Date: |
Mon, 6 Jun 2016 12:56:44 +0200 |
The code to exit the loop after bdrv_snapshot_delete_by_id_or_name()
returned failure was duplicated. The first copy of it was too early so
that the AioContext lock would not be freed. This patch removes it so
that only the second, correct copy remains.
Signed-off-by: Kevin Wolf <address@hidden>
---
block/snapshot.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/block/snapshot.c b/block/snapshot.c
index 6e6e34f..da89d2b 100644
--- a/block/snapshot.c
+++ b/block/snapshot.c
@@ -409,9 +409,6 @@ int bdrv_all_delete_snapshot(const char *name,
BlockDriverState **first_bad_bs,
if (bdrv_can_snapshot(bs) &&
bdrv_snapshot_find(bs, snapshot, name) >= 0) {
ret = bdrv_snapshot_delete_by_id_or_name(bs, name, err);
- if (ret < 0) {
- goto fail;
- }
}
aio_context_release(ctx);
if (ret < 0) {
--
1.8.3.1
- [Qemu-devel] [PATCH] block: Fix bdrv_all_delete_snapshot() error handling,
Kevin Wolf <=