[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PULL 04/16] Makefile: Rules for docker testing
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PULL 04/16] Makefile: Rules for docker testing |
Date: |
Mon, 6 Jun 2016 17:08:31 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.1.0 |
On 06/06/2016 17:02, Eduardo Habkost wrote:
> On Mon, Jun 06, 2016 at 04:32:50PM +0200, Paolo Bonzini wrote:
>> On 06/06/2016 16:15, Eduardo Habkost wrote:
>>>>> No, the second time you'll get the expansion of
>>>>>
>>>>> DOCKER_SRC_COPY := docker-src.$(CUR_TIME)
>>> And why it isn't enough to simply write the above line in the
>>> Makefile without any eval trick?
>>
>> Because 1) initially the idea was to delay the $(mkdir) too 2) Too many
>> $(shell) end up slowing down make.
>
> Now I see: you wanted to delay the shell command, but evaluate it
> only once.
>
> But I don't see why it makes sense here, because the variable is
> being expanded immediately after it is defined (in the
> "$(DOCKER_SRC_COPY):" line), and CUR_TIME is already defined
> using ":=".
Well, when I proposed the eval trick CUR_TIME was defined with "=". :)
I agree that right now it's all unnecessary.
Paolo
- Re: [Qemu-devel] [PULL 04/16] Makefile: Rules for docker testing, (continued)
- Re: [Qemu-devel] [PULL 04/16] Makefile: Rules for docker testing, Eduardo Habkost, 2016/06/03
- Re: [Qemu-devel] [PULL 04/16] Makefile: Rules for docker testing, Eduardo Habkost, 2016/06/03
- Re: [Qemu-devel] [PULL 04/16] Makefile: Rules for docker testing, Fam Zheng, 2016/06/06
- Re: [Qemu-devel] [PULL 04/16] Makefile: Rules for docker testing, Eduardo Habkost, 2016/06/06
- Re: [Qemu-devel] [PULL 04/16] Makefile: Rules for docker testing, Eduardo Habkost, 2016/06/06
- Re: [Qemu-devel] [PULL 04/16] Makefile: Rules for docker testing, Eduardo Habkost, 2016/06/06
- Re: [Qemu-devel] [PULL 04/16] Makefile: Rules for docker testing, Paolo Bonzini, 2016/06/06
- Re: [Qemu-devel] [PULL 04/16] Makefile: Rules for docker testing, Eduardo Habkost, 2016/06/06
- Re: [Qemu-devel] [PULL 04/16] Makefile: Rules for docker testing, Paolo Bonzini, 2016/06/06
- Re: [Qemu-devel] [PULL 04/16] Makefile: Rules for docker testing, Eduardo Habkost, 2016/06/06
- Re: [Qemu-devel] [PULL 04/16] Makefile: Rules for docker testing,
Paolo Bonzini <=
[Qemu-devel] [PULL 05/16] docker: Add images, Fam Zheng, 2016/06/01
[Qemu-devel] [PULL 02/16] rules.mak: Add "COMMA" constant, Fam Zheng, 2016/06/01
[Qemu-devel] [PULL 09/16] docker: Add full test, Fam Zheng, 2016/06/01
[Qemu-devel] [PULL 07/16] docker: Add common.rc, Fam Zheng, 2016/06/01
[Qemu-devel] [PULL 10/16] docker: Add clang test, Fam Zheng, 2016/06/01
[Qemu-devel] [PULL 08/16] docker: Add quick test, Fam Zheng, 2016/06/01
[Qemu-devel] [PULL 06/16] docker: Add test runner, Fam Zheng, 2016/06/01
[Qemu-devel] [PULL 12/16] docker: Add travis tool, Fam Zheng, 2016/06/01
[Qemu-devel] [PULL 13/16] docs: Add text for tests/docker in build-system.txt, Fam Zheng, 2016/06/01
[Qemu-devel] [PULL 14/16] docker: Add EXTRA_CONFIGURE_OPTS, Fam Zheng, 2016/06/01