[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] scsi-disk: add missing break
|
From: |
John Snow |
|
Subject: |
Re: [Qemu-devel] [PATCH] scsi-disk: add missing break |
|
Date: |
Mon, 6 Jun 2016 15:22:32 -0400 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.0 |
On 06/06/2016 06:34 AM, Paolo Bonzini wrote:
> Signed-off-by: Paolo Bonzini <address@hidden>
> ---
> hw/scsi/scsi-disk.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/hw/scsi/scsi-disk.c b/hw/scsi/scsi-disk.c
> index d5e8c8b..4b596d2 100644
> --- a/hw/scsi/scsi-disk.c
> +++ b/hw/scsi/scsi-disk.c
> @@ -2740,6 +2740,7 @@ static int32_t scsi_block_dma_command(SCSIRequest *req,
> uint8_t *buf)
> /* 10-byte CDB. */
> r->cdb1 = req->cmd.buf[1];
> r->group_number = req->cmd.buf[6];
> + break;
> case 4:
> /* 12-byte CDB. */
> r->cdb1 = req->cmd.buf[1];
>
Not that you need *my* review to pull something into your *own* branch, but:
Reviewed-by: John Snow <address@hidden>