[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 4/4] target-tricore: Added new JNE instructio
|
From: |
Bastian Koppelmann |
|
Subject: |
Re: [Qemu-devel] [PATCH v3 4/4] target-tricore: Added new JNE instruction variant |
|
Date: |
Tue, 7 Jun 2016 18:51:24 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.1.1 |
On 06/07/2016 05:49 PM, address@hidden wrote:
> From: Peer Adelt <address@hidden>
>
> If D[15] is != sign_ext(const4) then PC will be set to (PC +
> zero_ext(disp4 + 16)).
>
> Signed-off-by: Peer Adelt <address@hidden>
> ---
> target-tricore/translate.c | 16 ++++++++++++++++
> target-tricore/tricore-opcodes.h | 2 ++
> 2 files changed, 18 insertions(+)
>
Minor nitpick -- the commit message should reflect that you added the
JEQ variant as well. But I could do that when applying it to my
tricore-next tree.
Otherwise:
Reviewed-by: Bastian Koppelmann <address@hidden>
Cheers,
Bastian