Re: [Qemu-devel] [PATCH] Call cmp with "-s" instead of "--quiet"

[Peter Maydell]

On 11 June 2016 at 18:15, Sean Bruno <address@hidden> wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA512
>
>
>
> - --quiet isn't available on FreeBSD and doesn't seem to be used in
> other places.  This fixes some non-fatal build errors on FreeBSD.  The
> use of "-s" over "--quiet" seems to be the preferred use in the Makefile.
>
> diff --git a/Makefile b/Makefile
> index ed4032a..a7a356a 100644
> - --- a/Makefile
> +++ b/Makefile
> @@ -185,7 +185,7 @@ qemu-version.h: FORCE
>                                 printf '""\n'; \
>                         fi; \
>                 fi) > address@hidden)
> - -       $(call quiet-command, cmp --quiet $@ address@hidden || mv 
> address@hidden $@)
> +       $(call quiet-command, cmp -s $@ address@hidden || mv address@hidden 
> $@)
>
>  config-host.h: config-host.h-timestamp
>  config-host.h-timestamp: config-host.mak

Can you provide a Signed-off-by: for this patch, please?
We can't apply it without one.

(Providing it as a patch in the usual git format with
commit message would also be nice, but optional.)

thanks
-- PMM