qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v1 01/40] trace: add build framework for merging


From: Stefan Hajnoczi
Subject: Re: [Qemu-devel] [PATCH v1 01/40] trace: add build framework for merging trace-events files
Date: Tue, 14 Jun 2016 13:26:10 +0100
User-agent: Mutt/1.6.1 (2016-04-27)

On Thu, Jun 09, 2016 at 05:57:55PM +0100, Daniel P. Berrange wrote:
> +$(BUILD_DIR)/trace-events-all: $(trace-events-y:%=$(SRC_PATH)/%)
> +     $(call quiet-command,cat $^ > $@)

$^ needs to be a stable ordering across make invocations and across
machines to avoid thrashing ccache and spuriously renumbering trace
event IDs.

I guess it is stable but just in case anyone knows of a case where $^
would change order without any changes to the actual files (e.g.
readdir(2) returning things in a different order, make parallel jobs,
etc)...

Attachment: signature.asc
Description: PGP signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]