[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC PATCH] Change g_source_attach(xx, NULL) to g_souce
|
From: |
Eric Blake |
|
Subject: |
Re: [Qemu-devel] [RFC PATCH] Change g_source_attach(xx, NULL) to g_souce_attach(xx, g_main_context_get_thread_default()) |
|
Date: |
Mon, 20 Jun 2016 10:45:22 -0600 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 |
On 06/20/2016 02:23 AM, Zhang Chen wrote:
Subject line is too long, missing a 'topic:' prefix, and has a typo
(souce). Suggest:
qemu-char: Fix context for g_source_attach()
> We want to poll and handle chardev in another thread
> other than main loop. But qemu_chr_add_handlers() can only
> work for global default context other than thread default context.
> So we use g_souce_attach(xx, g_main_context_get_thread_default())
s/souce/source/
> replace g_source_attach(xx, NULL) to attach g_source.
> Comments form jason.
s/form/from/ ?
>
> Signed-off-by: Zhang Chen <address@hidden>
> Signed-off-by: Jason Wang <address@hidden>
> ---
> io/channel.c | 2 +-
> qemu-char.c | 6 +++---
> 2 files changed, 4 insertions(+), 4 deletions(-)
>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature