Re: [Qemu-devel] [PATCH RFC v2 3/5] tests: Make check-block a phony target

[Markus Armbruster]

Eric Blake <address@hidden> writes:

> On 06/24/2016 08:19 AM, Markus Armbruster wrote:
>> Forgotten in commit b8c6f29.
>
> Umm, really?  That commit starts with:
>
> tests/Makefile
> -.PHONY: check
> +
> +.PHONY: check check-block
>
> Rather, I think it was b93b63f5 that accidentally lost it during an
> overhaul.

Oops.  Will fix.

>> Signed-off-by: Markus Armbruster <address@hidden>
>> ---
>>  tests/Makefile.include | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>> 
>> diff --git a/tests/Makefile.include b/tests/Makefile.include
>> index 7b0446b..233cb9c 100644
>> --- a/tests/Makefile.include
>> +++ b/tests/Makefile.include
>> @@ -752,7 +752,7 @@ tests/headers/%.c: tests/header-test-template.c
>>  
>>  # Consolidated targets
>>  
>> -.PHONY: check-qapi-schema check-qtest check-unit check check-source 
>> check-clean
>> +.PHONY: check-qapi-schema check-qtest check-unit check check-block 
>> check-source check-clean
>
> Long line; worth splitting?

Yes.

> With commit message improved,
> Reviewed-by: Eric Blake <address@hidden>

Thanks!