[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH RFC] fixup! tests: New make target check-source
|
From: |
Sascha Silbe |
|
Subject: |
Re: [Qemu-devel] [PATCH RFC] fixup! tests: New make target check-source |
|
Date: |
Mon, 04 Jul 2016 13:16:44 +0200 |
|
User-agent: |
Notmuch/0.19+1~g6b3e223 (http://notmuchmail.org) Emacs/24.3.1 (x86_64-pc-linux-gnu) |
Dear Markus,
Markus Armbruster <address@hidden> writes:
> Markus Armbruster <address@hidden> writes:
>
>> Hmm, this demonstrates some of our headers may only be included when
>> certain CONFIG_* are defined.
[...]
>> Regardless, we need to find the problemtatic headers. Perhaps you can
>> find a few more with "make -k check-source".
>
> I think I tracked them down. Not too bad, just a dozen or so. Now I
> have to make up my mind whether I prefer to document their configuration
> requirements with comments or with ifdefs.
FWIW, I'd prefer a solution that allows successfully running "make
check-source" even on hosts where not all optional dependencies are
installed. It would be useful as a sanity check before sending
patches. If "make check-source" doesn't work on the developers primary
machine because they cannot install all the latest experimental
dependencies, fewer submitters will use it.
Sascha
--
Softwareentwicklung Sascha Silbe, Niederhofenstraße 5/1, 71229 Leonberg
https://se-silbe.de/
USt-IdNr. DE281696641