[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 16/32] blockdev: Move vpc probe to its own fi
From: |
Max Reitz |
Subject: |
Re: [Qemu-devel] [PATCH v3 16/32] blockdev: Move vpc probe to its own file |
Date: |
Wed, 6 Jul 2016 17:29:01 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.1.1 |
On 05.07.2016 17:24, Colin Lord wrote:
> Isolates vpc probe as part of the modularization process.
>
> Signed-off-by: Colin Lord <address@hidden>
> ---
> block/Makefile.objs | 2 +-
> block/probe/vpc.c | 9 +++++++++
> block/vpc.c | 8 +-------
> include/block/probe.h | 1 +
> 4 files changed, 12 insertions(+), 8 deletions(-)
> create mode 100644 block/probe/vpc.c
Reviewed-by: Max Reitz <address@hidden>
[...]
> diff --git a/block/probe/vpc.c b/block/probe/vpc.c
> new file mode 100644
> index 0000000..afe8271
> --- /dev/null
> +++ b/block/probe/vpc.c
> @@ -0,0 +1,9 @@
> +#include "qemu/osdep.h"
> +#include "block/probe.h"
> +
> +int vpc_probe(const uint8_t *buf, int buf_size, const char *filename)
> +{
> + if (buf_size >= 8 && !strncmp((char *)buf, "conectix", 8))
> + return 100;
*cough*
> + return 0;
> +}
signature.asc
Description: OpenPGP digital signature
- Re: [Qemu-devel] [PATCH v3 26/32] blockdev: Separate vdi probe from its driver, (continued)
- [Qemu-devel] [PATCH v3 29/32] blockdev: Separate vpc probe from its driver, Colin Lord, 2016/07/05
- [Qemu-devel] [PATCH v3 31/32] blockdev: Separate out bdrv_probe_device functions, Colin Lord, 2016/07/05
- [Qemu-devel] [PATCH v3 30/32] blockdev: Remove the .bdrv_probe field from BlockDrivers, Colin Lord, 2016/07/05
- [Qemu-devel] [PATCH v3 32/32] blockdev: Remove bdrv_probe_device field from BlockDriver, Colin Lord, 2016/07/05
- [Qemu-devel] [PATCH v3 16/32] blockdev: Move vpc probe to its own file, Colin Lord, 2016/07/05
- Re: [Qemu-devel] [PATCH v3 16/32] blockdev: Move vpc probe to its own file,
Max Reitz <=
- [Qemu-devel] [PATCH v3 17/32] blockdev: Separate bochs probe from its driver, Colin Lord, 2016/07/05
- [Qemu-devel] [PATCH v3 22/32] blockdev: Separate qcow probe from its driver, Colin Lord, 2016/07/05
- [Qemu-devel] [PATCH v3 21/32] blockdev: Separate parallels probe from its driver, Colin Lord, 2016/07/05
- [Qemu-devel] [PATCH v3 27/32] blockdev: Separate vhdx probe from its driver, Colin Lord, 2016/07/05