[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] qapi: change QmpOutputVisitor to QSLIST
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH] qapi: change QmpOutputVisitor to QSLIST |
Date: |
Wed, 6 Jul 2016 09:32:16 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 |
On 07/06/2016 06:43 AM, Paolo Bonzini wrote:
> This saves a little memory compared to the doubly-linked QTAILQ.
>
> Signed-off-by: Paolo Bonzini <address@hidden>
> ---
> qapi/qmp-output-visitor.c | 25 +++++++++----------------
> 1 file changed, 9 insertions(+), 16 deletions(-)
>
> struct QmpOutputVisitor
> {
> Visitor visitor;
> - QStack stack; /* Stack of containers that haven't yet been finished */
> + QSLIST_HEAD(, QStackEntry) stack; /* Stack of containers that haven't
> yet been finished */
Long line now, a simple reword would avoid a need to wrap:
QSLIST_HEAD(...); /* Stack of unfinished containers */
Maintainer could fix it, so:
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
Re: [Qemu-devel] [PATCH] qapi: change QmpOutputVisitor to QSLIST,
Eric Blake <=
Re: [Qemu-devel] [PATCH] qapi: change QmpOutputVisitor to QSLIST, Markus Armbruster, 2016/07/07