Re: [Qemu-devel] [PATCH v3 08/19] pc: implement query-hotpluggable-cpus callback

[Igor Mammedov]

On Mon, 11 Jul 2016 23:54:42 -0300
Eduardo Habkost <address@hidden> wrote:

> On Wed, Jul 06, 2016 at 08:20:44AM +0200, Igor Mammedov wrote:
> > it returns a list of present/possible to hotplug CPU
> > objects with a list of properties to use with
> > device_add.
> > 
> > in PC case returned list would looks like:  
> > -> { "execute": "query-hotpluggable-cpus" }  
> > <- {"return": [
> >      {
> >         "type": "qemu64-x86_64-cpu", "vcpus-count": 1,
> >         "props": {"core-id": 0, "socket-id": 1, "thread-id": 0}
> >      },
> >      {
> >         "qom-path": "/machine/unattached/device[0]",
> >         "type": "qemu64-x86_64-cpu", "vcpus-count": 1,
> >         "props": {"core-id": 0, "socket-id": 0, "thread-id": 0}
> >      }
> >    ]}
> > 
> > Signed-off-by: Igor Mammedov <address@hidden>  
> 
> Reviewed-by: Eduardo Habkost <address@hidden>
> 
> But shouldn't this be at the end of the series, or at least after
> the code that makes device_add work with X86CPU?
sure, I'll move it there