[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] checkpatch: consider git extended headers valid
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH] checkpatch: consider git extended headers valid patches |
Date: |
Fri, 15 Jul 2016 11:52:21 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 |
On 07/15/2016 03:46 AM, Stefan Hajnoczi wrote:
> Renames look like this with git-diff(1) when diff.renames = true is set:
>
> diff --git a/a b/b
> similarity index 100%
> rename from a
> rename to b
>
> This raises the "Does not appear to be a unified-diff format patch"
> error because checkpatch.pl only considers a diff valid if it contains
> at least one "@@" hunk.
>
> This patch accepts renames and copies too so that checkpatch.pl exits
> successfully when a diff only renames/copies files. The git diff
> extended header format is described on the git-diff(1) man page.
>
> Reported-by: Colin Lord <address@hidden>
> Signed-off-by: Stefan Hajnoczi <address@hidden>
> ---
> scripts/checkpatch.pl | 5 +++++
> 1 file changed, 5 insertions(+)
Reviewed-by: Eric Blake <address@hidden>
and especially nice since we recommend diff.renames = true in our patch
submission guidelines.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature