[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/3] qdist: fix memory leak during binning
From: |
Marc-André Lureau |
Subject: |
Re: [Qemu-devel] [PATCH 1/3] qdist: fix memory leak during binning |
Date: |
Tue, 26 Jul 2016 12:42:40 +0400 |
Hi
On Mon, Jul 25, 2016 at 7:03 PM, Emilio G. Cota <address@hidden> wrote:
> In qdist_bin__internal(), to->entries is initialized to a 1-element array,
> which we then leak when n == from->n. Fix it.
>
> Signed-off-by: Emilio G. Cota <address@hidden>
> ---
> util/qdist.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/util/qdist.c b/util/qdist.c
> index 56f5738..eb2236c 100644
> --- a/util/qdist.c
> +++ b/util/qdist.c
> @@ -188,7 +188,7 @@ void qdist_bin__internal(struct qdist *to, const struct
> qdist *from, size_t n)
> }
> }
> /* they're equally spaced, so copy the dist and bail out */
> - to->entries = g_new(struct qdist_entry, from->n);
> + to->entries = g_realloc_n(to->entries, n, sizeof(*to->entries));
This is already part of the leak series:
https://lists.gnu.org/archive/html/qemu-devel/2016-07/msg04168.html
> to->n = from->n;
> memcpy(to->entries, from->entries, sizeof(*to->entries) * to->n);
> return;
> --
> 2.5.0
>
>
--
Marc-André Lureau