Re: [Qemu-devel] [RFC PATCH V3 0/3] filter-rewriter: introduce filter-rewriter

[Zhang Chen]

Hi~ all~~

Anyone have some comments for this series?

We need more comments to improve COLO codes.


Thanks

Zhang Chen


On 07/05/2016 06:29 PM, Zhang Chen wrote:
> Filter-rewriter is a part of COLO project.
> So this patch set depend on colo-compare.
> It will rewrite some of secondary packet to make
> secondary guest's connection established successfully.
> In this module we will rewrite tcp packet's ack to the secondary
> from primary,and rewrite tcp packet's seq to the primary from
> secondary.
>
> v3:
>    - fix typo
>    - add conn->syn_flag
>    - add some comments
>    - remove conn_list_lock
>    - fix offset set bug
>
> v2:
>    - add more comments about packet flows
>    - add some trace-event
>    - add seq offset ( = secondary_seq - primary_seq)
>
> v1:
>    - initial patch
>
> Zhang Chen (3):
>    filter-rewriter: introduce filter-rewriter initialization
>    filter-rewriter: track connection and parse packet
>    filter-rewriter: rewrite tcp packet to keep secondary connection
>
>   net/Makefile.objs     |   1 +
>   net/colo-base.c       |   2 +
>   net/colo-base.h       |   7 ++
>   net/filter-rewriter.c | 262 ++++++++++++++++++++++++++++++++++++++++++++++++++
>   qemu-options.hx       |  13 +++
>   trace-events          |   5 +
>   vl.c                  |   3 +-
>   7 files changed, 292 insertions(+), 1 deletion(-)
>   create mode 100644 net/filter-rewriter.c

--
Thanks
zhangchen