Re: [Qemu-devel] [RFC PATCH V3 0/3] filter-rewriter: introduce filter-rewriter

[Jason Wang]

On 2016年07月27日 15:52, Zhang Chen wrote:
> On 07/27/2016 03:05 PM, Jason Wang wrote:
> > On 2016年07月27日 13:49, Zhang Chen wrote:
> > > On 07/27/2016 10:50 AM, Jason Wang wrote:
> > > > On 2016年07月27日 10:32, Zhang Chen wrote:
> > > > > Hi~ all~~
> > > > >
> > > > > Anyone have some comments for this series?
> > > >
> > > > Will have a look at this.
> > > >
> > > > Btw. I wonder how this is tested, do we need a unit test for this?
> > >
> > > COLO-compare and filter-rewriter works normal depend on colo-frame.
> > > So, When colo-frame be merged I will send a colo-proxy unit test
> > > for all filter-mirror,filter-redirector,colo-compare,filter-rewriter.
> >
> > Sounds cool.
> >
> > > > > We need more comments to improve COLO codes.
> > > > >
> > > > >
> > > > > Thanks
> > > > >
> > > > > Zhang Chen
> > > > >
> > > > >
> > > > > On 07/05/2016 06:29 PM, Zhang Chen wrote:
> > > > > > Filter-rewriter is a part of COLO project.
> > > > > > So this patch set depend on colo-compare.
> > > >
> > > > Interesting, I thought it can co-work with comparing, and the 
> > > > communication were done through socket now. So I think technically 
> > > > the filter itself could work without COLO?
> > >
> > > Filter-rewriter can run without COLO, but it no sense for other people.
> > > rewriter need TX tcp packet differ with RX tcp packet...
> > > In normal qemu we can't get the environment same with COLO.
> >
> > Then I suggest to add this to the colo comparing series.
>
> OK~~
> BTW, Should we make independent the "qemu-char" patch to compare series?
> This patch just add a API in qemu-char.c ....
>
> Thanks
> Zhang Chen 

I think yes, and better make it patch 1.

Thanks