Re: [Qemu-devel] [PATCH v2] Move migrate_set_speed and migrate_set_downtime into migrate_set_parameter

[Paolo Bonzini]

On 05/09/2016 13:59, Ashijeet Acharya wrote:
>>> >> +    if (has_migrate_set_speed) {
>>> >> +        qmp_migrate_set_speed(migrate_set_speed, NULL);
>>> >> +    }
>>> >> +    if (has_migrate_set_downtime) {
>>> >> +        qmp_migrate_set_downtime(migrate_set_downtime, NULL);
>>> >> +    }
>> >
>> > This is backwards; qmp_migrate_set_speed and qmp_migrate_set_downtime
>> > should be implemented in terms of qmp_migrate_set_parameters, not the
>> > other way round.
> 
> Okay. Got it!

Thinking more about it, it's even better to have two patches.  One doing
it this way (qmp_migrate_set_parameters calls the old functions), the
second that reverses the direction.

Thanks!

Paolo