qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v2] Move migrate_set_speed and migrate_set_downt


From: Paolo Bonzini
Subject: Re: [Qemu-devel] [PATCH v2] Move migrate_set_speed and migrate_set_downtime into migrate_set_parameter
Date: Mon, 5 Sep 2016 15:16:04 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0


On 05/09/2016 15:09, Ashijeet Acharya wrote:
>>> >> +            
>>> >> "compress-level:i?,compress-threads:i?,decompress-threads:i?,cpu-throttle-initial:i?,cpu-throttle-increment:i?,migrate-set-speed:o?,migrate-set-downtime:T?",
>> >
>> > Same here about the names.  Also use "i" for QMP commands.
> I think we will have to use "T" for downtime at-least otherwise you
> cant use float values for setting seconds like "0.2" for example.
> No issues using "i" with bandwidth though.

Right, I should have mentioned that my remark was about the "o" (it
caught my eye because of your change to hmp-commands.hx).  Sorry!

Paolo



reply via email to

[Prev in Thread] Current Thread [Next in Thread]