Re: [Qemu-devel] [PATCH 0/9] target-mips: Add Enhanced Virtual Addressing (EVA) support

[James Hogan]

On Tue, Sep 06, 2016 at 04:18:38AM -0700, address@hidden wrote:
> Checking PATCH 1/9: target-mips: Add CP0_Ebase.WG (write gate) support...
> ERROR: space prohibited after that '&' (ctx:WxW)
> #104: FILE: target-mips/op_helper.c:1529:
> +    if (arg1 & (1 << CP0EBase_WG) & env->CP0_EBase_rw_bitmask) {
>                                    ^
> 
> ERROR: space prohibited after that '&' (ctx:WxW)
> #116: FILE: target-mips/op_helper.c:1540:
> +    if (arg1 & (1 << CP0EBase_WG) & env->CP0_EBase_rw_bitmask) {
>                                    ^

its a bitwise and operator, not an address-of operator, so I presumed
this was a false positive.

> Checking PATCH 6/9: target-mips: Add an MMU mode for ERL...
> ERROR: trailing statements should be on next line
> #94: FILE: target-mips/op_helper.c:97:
> +    case 3: cpu_##insn##_error_ra(env, addr, val, retaddr); break;      \

And this is merely consistent with the surrounding lines so I didn't
bother fixing it.

Cheers
James

signature.asc
Description: Digital signature