Re: [Qemu-devel] [PATCH] Move migrate_set_speed and migrate_set_downtime into migrate_set_parameter

[Juan Quintela]

"Dr. David Alan Gilbert" <address@hidden> wrote:
> * Ashijeet Acharya (address@hidden) wrote:
>> On Mon, Sep 5, 2016 at 1:46 PM, Paolo Bonzini <address@hidden> wrote:
>> >
>> >
>> > On 05/09/2016 10:11, Ashijeet Acharya wrote:
>> >> > > Include migrate_set_speed and migrate_set_downtime inside
>> >> > > migrate_set_parameters respectively for setting maximum migration
>> >> > > speed and expected downtime parameters. Also add the query part for
>> >> > > both in qmp and hmp qemu control interfaces.
>> >> > >
>> >> > > Signed-off-by: Ashijeet Acharya <address@hidden>
>> >> >
>> >> > You cannot break backwards compatibility for everyone that is using
>> >> > those commands, sorry.
>> >>
>> >> So should I keep the old commands too and add the new ones anyway for
>> >> the query part?
>> >
>> > You do not need query for the old ones, but you can indeed add support
>> > for speed and downtime in migrate-set-parameters and MigrationParameters.
>> 
>> Right. So I will add the old-commands back and just add support for the new 
>> ones
>> under migration-set-parameters along with the query.
>
> Yes add them to both migrate_set_parameters and query_migrate_parameters
> and the hmp equivalents; but don't remove the old functions; just make
> them simple wrappers to call the migrate_set_parameters etc.
> Add a comment on them like 'kept for compatibility'.

I agree with that approach.

Thanks, Juan.

>
> Dave
>
>> > (Note: I'm not a migration maintainer, so they might say something else).
>> 
>> Okay. I will wait for their views too.
>> 
>> Ashijeet
>> >
>> > Paolo
>> >
>> >> The old ones will also be modified for query. So we will have
>> >> compatibility as well as the
>> >> query.
> --
> Dr. David Alan Gilbert / address@hidden / Manchester, UK