[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 1/7] docker.py: don't hang on large docker ou
|
From: |
Sascha Silbe |
|
Subject: |
Re: [Qemu-devel] [PATCH v2 1/7] docker.py: don't hang on large docker output |
|
Date: |
Tue, 06 Sep 2016 20:31:44 +0200 |
|
User-agent: |
Notmuch/0.22.1~rc0 (http://notmuchmail.org) Emacs/24.3.1 (x86_64-pc-linux-gnu) |
Dear Fam,
Fam Zheng <address@hidden> writes:
> On Wed, 08/24 20:30, Sascha Silbe wrote:
[tests/docker/docker.py]
>> @@ -25,6 +25,10 @@ from tarfile import TarFile, TarInfo
>> from StringIO import StringIO
>> from shutil import copy, rmtree
>>
>> +
>> +DEVNULL = open(os.devnull, 'wb')
>> +
>> +
>
> Too many blank lines? Otherwise looks good.
You caught me sneaking in a PEP-8 compliance fix. ;)
Is qemu using a custom code style for Python sources? If so, is it
documented somewhere?
Thanks for reviewing!
Sascha
--
Softwareentwicklung Sascha Silbe, Niederhofenstraße 5/1, 71229 Leonberg
https://se-silbe.de/
USt-IdNr. DE281696641