Re: [Qemu-devel] [PATCH v2 1/7] docker.py: don't hang on large docker output

[Fam Zheng]

On Tue, 09/06 20:31, Sascha Silbe wrote:
> Dear Fam,
> 
> Fam Zheng <address@hidden> writes:
> 
> > On Wed, 08/24 20:30, Sascha Silbe wrote:
> [tests/docker/docker.py]
> >> @@ -25,6 +25,10 @@ from tarfile import TarFile, TarInfo
> >>  from StringIO import StringIO
> >>  from shutil import copy, rmtree
> >>  
> >> +
> >> +DEVNULL = open(os.devnull, 'wb')
> >> +
> >> +
> >
> > Too many blank lines? Otherwise looks good.
> 
> You caught me sneaking in a PEP-8 compliance fix. ;)

Ah, no problem. I just didn't know.

> 
> Is qemu using a custom code style for Python sources? If so, is it
> documented somewhere?

No, and following PEP-8 is completely fine.

Fam

> 
> Thanks for reviewing!
> 
> Sascha
> -- 
> Softwareentwicklung Sascha Silbe, Niederhofenstraße 5/1, 71229 Leonberg
> https://se-silbe.de/
> USt-IdNr. DE281696641
> 
>