[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v1 11/14] virtio-crypto: add control queue handl
From: |
Michael S. Tsirkin |
Subject: |
Re: [Qemu-devel] [PATCH v1 11/14] virtio-crypto: add control queue handler |
Date: |
Thu, 8 Sep 2016 07:30:00 +0300 |
On Thu, Sep 08, 2016 at 11:42:33AM +0800, Gonglei wrote:
> + info->cipher_alg = virtio_ldl_p(vdev, &cipher_para->algo);
> + info->key_len = virtio_ldl_p(vdev, &cipher_para->keylen);
> + info->direction = virtio_ldl_p(vdev, &cipher_para->op);
There is no reason to use the virtio mixed endian-ness for
modern devices. Just use little-endian everywhere.
- [Qemu-devel] [PATCH v1 06/14] crypto: add internal handle logic layer, (continued)
- [Qemu-devel] [PATCH v1 06/14] crypto: add internal handle logic layer, Gonglei, 2016/09/07
- [Qemu-devel] [PATCH v1 01/14] crypto: introduce cryptodev backend and crypto legacy hardware, Gonglei, 2016/09/07
- [Qemu-devel] [PATCH v1 03/14] crypto: add cryptoLegacyHW stuff, Gonglei, 2016/09/07
- [Qemu-devel] [PATCH v1 12/14] virtio-crypto: add destroy session logic, Gonglei, 2016/09/07
- [Qemu-devel] [PATCH v1 05/14] crypto: add cryptodev-linux as a cryptodev backend, Gonglei, 2016/09/07
- [Qemu-devel] [PATCH v1 07/14] virtio-crypto: introduce virtio-crypto.h, Gonglei, 2016/09/07
- [Qemu-devel] [PATCH v1 14/14] virtio-crypto: add data virtqueue processing handler, Gonglei, 2016/09/07
- [Qemu-devel] [PATCH v1 13/14] virtio-crypto: get correct input data address for each request, Gonglei, 2016/09/07
- [Qemu-devel] [PATCH v1 10/14] virtio-crypto: set capacity of crypto legacy hardware, Gonglei, 2016/09/07
- [Qemu-devel] [PATCH v1 11/14] virtio-crypto: add control queue handler, Gonglei, 2016/09/07
- Re: [Qemu-devel] [PATCH v1 11/14] virtio-crypto: add control queue handler,
Michael S. Tsirkin <=
- [Qemu-devel] [PATCH v1 09/14] virtio-crypto: add virtio crypto realization modle, Gonglei, 2016/09/07
- [Qemu-devel] [PATCH v1 08/14] virtio-crypto-pci: add virtio crypto pci support, Gonglei, 2016/09/07
- [Qemu-devel] [PATCH v1 02/14] crypto: introduce crypto queue handler, Gonglei, 2016/09/07
- [Qemu-devel] [PATCH v1 04/14] crypto: add symetric algorithms support, Gonglei, 2016/09/07
- Re: [Qemu-devel] [PATCH v1 00/14] virtio-crypto: introduce framework and device emulation, no-reply, 2016/09/08