Re: [Qemu-devel] [virtio-dev] Re: [PATCH v1 11/14] virtio-crypto: add control queue handler

[Gonglei (Arei)]

> -----Original Message-----
> From: address@hidden [mailto:address@hidden
> On Behalf Of Michael S. Tsirkin
> Sent: Thursday, September 08, 2016 12:30 PM
> To: Gonglei (Arei)
> Subject: [virtio-dev] Re: [PATCH v1 11/14] virtio-crypto: add control queue
> handler
> 
> On Thu, Sep 08, 2016 at 11:42:33AM +0800, Gonglei wrote:
> > +    info->cipher_alg = virtio_ldl_p(vdev, &cipher_para->algo);
> > +    info->key_len = virtio_ldl_p(vdev, &cipher_para->keylen);
> > +    info->direction = virtio_ldl_p(vdev, &cipher_para->op);
> 
> There is no reason to use the virtio mixed endian-ness for
> modern devices. Just use little-endian everywhere.
> 
Okay, thanks :)


Regards,
-Gonglei