Re: [Qemu-devel] [PATCH v6 15/18] monitor: use qmp_dispatch()

[Marc-André Lureau]

----- Original Message -----
> Hi Alberto
> 
> ----- Original Message -----
> > On Mon, Sep 12, 2016 at 01:19:10PM +0400, Marc-André Lureau wrote:
> > > Replace the old manual dispatch and validation code by the generic one
> > > provided by qapi common code.
> > > 
> > > Note that it is now possible to call the following commands that used to
> > > be disabled by compile-time conditionals:
> > > - dump-skeys
> > > - query-spice
> > > - rtc-reset-reinjection
> > > - query-gic-capabilities
> > > 
> > > Their fallback functions return an appropriate "feature disabled" error.
> > > 
> > > Signed-off-by: Marc-André Lureau <address@hidden>
> > 
> > This patch breaks iotest 085 because the "missing parameter" error is
> > now different:
> > 
> > -{"error": {"class": "GenericError", "desc": "Parameter 'snapshot-file' is
> > missing"}}
> > +{"error": {"class": "GenericError", "desc": "Invalid parameter type for
> > 'snapshot-file', expected: string"}}
> > 
> > I was thinking to update the expected output of the iotest, but I
> > guess it's better to return a more meaningful error message?
> 
> The change is relatively easy (see attached patch), but there are other tests
> that expected the current error, see commit fe509ee237307843. I guess we
> should decided with one, and I think missing parameter is more appropriate.
> 

diff attached

qapi-missingp.patch
Description: Text Data