Re: [Qemu-devel] [PATCH v7 10/12] cryptodev: introduce an unified wrapper for crypto operation

[Gonglei (Arei)]

> -----Original Message-----
> From: Stefan Hajnoczi [mailto:address@hidden
> Sent: Sunday, October 16, 2016 9:26 PM
> Subject: Re: [Qemu-devel] [PATCH v7 10/12] cryptodev: introduce an unified
> wrapper for crypto operation
> 
> On Thu, Oct 13, 2016 at 03:12:04PM +0800, Gonglei wrote:
> > We use an opaque point to the VirtIOCryptoReq which
> > can support different packets based on different
> > algorithms.
> >
> > Signed-off-by: Gonglei <address@hidden>
> > ---
> >  backends/cryptodev-builtin.c |  2 +-
> >  backends/cryptodev.c         | 28 ++++++++++++++++++++++++++--
> >  hw/virtio/virtio-crypto.c    | 10 +++++-----
> >  include/sysemu/cryptodev.h   | 13 +++++++------
> >  4 files changed, 39 insertions(+), 14 deletions(-)
> >
> > diff --git a/backends/cryptodev-builtin.c b/backends/cryptodev-builtin.c
> > index 34c45be..dc0a364 100644
> > --- a/backends/cryptodev-builtin.c
> > +++ b/backends/cryptodev-builtin.c
> > @@ -286,7 +286,7 @@ static int cryptodev_builtin_sym_operation(
> >              return -VIRTIO_CRYPTO_ERR;
> >          }
> >      }
> > -    return 0;
> > +    return VIRTIO_CRYPTO_OK;
> >  }
> 
> This looks unrelated to the commit description.  Please squash the
> VIRTIO_CRYPTO_OK changes into the patches that introduced the old code
> that you are replacing.

OK, I'll rebase it.


Regards,
-Gonglei