[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v7 12/12] virtio-crypto: perfect algorithms chai
From: |
Gonglei (Arei) |
Subject: |
Re: [Qemu-devel] [PATCH v7 12/12] virtio-crypto: perfect algorithms chainning support |
Date: |
Mon, 17 Oct 2016 06:33:32 +0000 |
> -----Original Message-----
> From: Stefan Hajnoczi [mailto:address@hidden
> Sent: Sunday, October 16, 2016 9:30 PM
> Subject: Re: [Qemu-devel] [PATCH v7 12/12] virtio-crypto: perfect algorithms
> chainning support
>
> On Thu, Oct 13, 2016 at 03:12:06PM +0800, Gonglei wrote:
> > diff --git a/include/standard-headers/linux/virtio_crypto.h
> b/include/standard-headers/linux/virtio_crypto.h
> > index f2a059e..9ae02fb 100644
> > --- a/include/standard-headers/linux/virtio_crypto.h
> > +++ b/include/standard-headers/linux/virtio_crypto.h
> > @@ -326,7 +326,15 @@ struct virtio_crypto_mac_data_req {
> > };
> >
> > struct virtio_crypto_alg_chain_data_para {
> > - struct virtio_crypto_cipher_para cipher;
> > + __virtio32 iv_len;
> > + /* Length of source data */
> > + __virtio32 src_data_len;
> > + /* Length of destination data */
> > + __virtio32 dst_data_len;
> > + /* Starting point for cipher processing in source data */
> > + __virtio32 cipher_start_src_offset;
> > + /* Length of the source data that the cipher will be computed on */
> > + __virtio32 len_to_cipher;
> > /* Starting point for hash processing in source data */
> > __virtio32 hash_start_src_offset;
> > /* Length of the source data that the hash will be computed on */
> > @@ -335,6 +343,7 @@ struct virtio_crypto_alg_chain_data_para {
> > __virtio32 aad_len;
> > /* Length of the hash result */
> > __virtio32 hash_result_len;
> > + __virtio32 reserved;
> > };
> >
> > struct virtio_crypto_alg_chain_data_req {
>
> This is supposed to be an external header file from Linux. QEMU patches
> normally don't change the file except to import an updated version.
>
> Please import the final version once in the patch series and don't
> modify it.
You are right. Will fix it. :)
Regards,
-Gonglei
- [Qemu-devel] [PATCH v7 11/12] virtio-crypto: add myself as virtio-crypto and cryptodev backends maintainer, (continued)
- [Qemu-devel] [PATCH v7 11/12] virtio-crypto: add myself as virtio-crypto and cryptodev backends maintainer, Gonglei, 2016/10/13
- [Qemu-devel] [PATCH v7 01/12] cryptodev: introduce cryptodev backend interface, Gonglei, 2016/10/13
- [Qemu-devel] [PATCH v7 06/12] virtio-crypto-pci: add virtio crypto pci support, Gonglei, 2016/10/13
- [Qemu-devel] [PATCH v7 05/12] virtio-crypto: add virtio crypto device emulation, Gonglei, 2016/10/13
- [Qemu-devel] [PATCH v7 10/12] cryptodev: introduce an unified wrapper for crypto operation, Gonglei, 2016/10/13
- [Qemu-devel] [PATCH v7 02/12] cryptodev: add symmetric algorithm operation stuff, Gonglei, 2016/10/13
- [Qemu-devel] [PATCH v7 12/12] virtio-crypto: perfect algorithms chainning support, Gonglei, 2016/10/13
- [Qemu-devel] [PATCH v7 04/12] cryptodev: introduce a new cryptodev backend, Gonglei, 2016/10/13
- [Qemu-devel] [PATCH v7 07/12] virtio-crypto: set capacity of algorithms supported, Gonglei, 2016/10/13
- [Qemu-devel] [PATCH v7 03/12] virtio-crypto: introduce virtio_crypto.h, Gonglei, 2016/10/13
- [Qemu-devel] [PATCH v7 08/12] virtio-crypto: add control queue handler, Gonglei, 2016/10/13
- Re: [Qemu-devel] [PATCH v7 00/12] virtio-crypto: introduce framework and device emulation, no-reply, 2016/10/13