[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 1/8] tests: check-qom-proplist: Remove duplic
From: |
Igor Mammedov |
Subject: |
Re: [Qemu-devel] [PATCH v3 1/8] tests: check-qom-proplist: Remove duplicate "bv" property |
Date: |
Thu, 27 Oct 2016 16:13:10 +0200 |
On Wed, 26 Oct 2016 14:30:19 -0200
Eduardo Habkost <address@hidden> wrote:
> The object_property_add_bool() call in dummy_init() is always
> failing because there is an existing "bv" class property. We need
> to remove either the "bv" class property or the "bv" instance
> property.
>
> Remove the class property so both object properties and class
> properties are covered by the test code.
>
> Signed-off-by: Eduardo Habkost <address@hidden>
Reviewed-by: Igor Mammedov <address@hidden>
> ---
> Changes series v2 -> v3:
> * Reworded commit message for clarity
> ---
> tests/check-qom-proplist.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/tests/check-qom-proplist.c b/tests/check-qom-proplist.c
> index a16cefc..693dc4c 100644
> --- a/tests/check-qom-proplist.c
> +++ b/tests/check-qom-proplist.c
> @@ -129,10 +129,6 @@ static void dummy_init(Object *obj)
>
> static void dummy_class_init(ObjectClass *cls, void *data)
> {
> - object_class_property_add_bool(cls, "bv",
> - dummy_get_bv,
> - dummy_set_bv,
> - NULL);
> object_class_property_add_str(cls, "sv",
> dummy_get_sv,
> dummy_set_sv,
- [Qemu-devel] [PATCH v3 0/8] qdev class properties + abstract class support on device-list-properties, Eduardo Habkost, 2016/10/26
- [Qemu-devel] [PATCH v3 1/8] tests: check-qom-proplist: Remove duplicate "bv" property, Eduardo Habkost, 2016/10/26
- Re: [Qemu-devel] [PATCH v3 1/8] tests: check-qom-proplist: Remove duplicate "bv" property,
Igor Mammedov <=
- [Qemu-devel] [PATCH v3 2/8] tests: check-qom-proplist: Use &error_abort to catch errors, Eduardo Habkost, 2016/10/26
- [Qemu-devel] [PATCH v3 4/8] qdev: Extract property-default code to qdev_property_set_to_default(), Eduardo Habkost, 2016/10/26
- [Qemu-devel] [PATCH v3 6/8] qom: object_class_property_iter_init() function, Eduardo Habkost, 2016/10/26
- [Qemu-devel] [PATCH v3 5/8] qdev: Register static properties as class properties, Eduardo Habkost, 2016/10/26