Re: [Qemu-devel] [PULL 00/47] virtio, pc: fixes and features

[Peter Maydell]

On 31 October 2016 at 22:48, Michael S. Tsirkin <address@hidden> wrote:
> On Mon, Oct 31, 2016 at 10:50:31AM +0100, Igor Mammedov wrote:
>> On Sun, 30 Oct 2016 23:23:18 +0200
>> "Michael S. Tsirkin" <address@hidden> wrote:
>>
>> > The following changes since commit 
>> > 5b2ecabaeabc17f032197246c4846b9ba95ba8a6:
>> >
>> >   Merge remote-tracking branch 'remotes/kraxel/tags/pull-ui-20161028-1' 
>> > into staging (2016-10-28 17:59:04 +0100)
>> >
>> > are available in the git repository at:
>> >
>> >   git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git tags/for_upstream
>> >
>> > for you to fetch changes up to f082ec0225bd15c71e0b4697d2df3af7bad65d7f:
>> >
>> >   acpi: fix assert failure caused by commit 35c5a52d (2016-10-30 20:06:25 
>> > +0200)
>> >
>> > ----------------------------------------------------------------
>> > virtio, pc: fixes and features
>> >
>> > nvdimm hotplug support
>> Michael,
>>
>> Could you drop nvdimm hotplug from pull request (I should review at least 
>> once as it touches not only NVDIMMs but a generic hotplug infrastructure)
>>
>> and keep only nvdimm fixes/cleanups for now?
>
> If I drop it now it won't be in the next QEMU and it seems like
> a valuable feature. The comments so far are about minor style
> improvements that IMO can be addressed by patches on top.
>
> We can always revert if you see bigger issues, but let's enable the
> testing of this feature.

I'm waiting for a reply from Igor before I do anything with
this pull request.

thanks
-- PMM