qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v3 01/14] qapi: add missing 'bus' argument in de


From: Eric Blake
Subject: Re: [Qemu-devel] [PATCH v3 01/14] qapi: add missing 'bus' argument in device_add
Date: Mon, 7 Nov 2016 16:55:43 -0600
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0

On 11/07/2016 01:30 AM, Marc-André Lureau wrote:
> 'device_add' is incomplete for now, but 'bus' is a common argument for
> regarless of the device, and is present in documentation. Add it to the

s/regarless/regardless/

> device_add schema definition.
> 
> Signed-off-by: Marc-André Lureau <address@hidden>
> ---
>  qapi-schema.json | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/qapi-schema.json b/qapi-schema.json
> index b0b4bf6..4ba5772 100644
> --- a/qapi-schema.json
> +++ b/qapi-schema.json
> @@ -2317,7 +2317,7 @@
>  # Since: 0.13
>  ##
>  { 'command': 'device_add',
> -  'data': {'driver': 'str', 'id': 'str'},
> +  'data': {'driver': 'str', '*bus': 'str', 'id': 'str'},
>    'gen': false } # so we can get the additional arguments
>  
>  ##
> 

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]