Re: [Qemu-devel] [PATCH v3 01/14] qapi: add missing 'bus' argument in device_add

[Markus Armbruster]

Marc-André Lureau <address@hidden> writes:

> 'device_add' is incomplete for now, but 'bus' is a common argument for
> regarless of the device, and is present in documentation. Add it to the
> device_add schema definition.
>
> Signed-off-by: Marc-André Lureau <address@hidden>
> ---
>  qapi-schema.json | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/qapi-schema.json b/qapi-schema.json
> index b0b4bf6..4ba5772 100644
> --- a/qapi-schema.json
> +++ b/qapi-schema.json
> @@ -2317,7 +2317,7 @@
>  # Since: 0.13
>  ##
>  { 'command': 'device_add',
> -  'data': {'driver': 'str', 'id': 'str'},
> +  'data': {'driver': 'str', '*bus': 'str', 'id': 'str'},
>    'gen': false } # so we can get the additional arguments
>  
>  ##

Makes sense.

@id is actually optional, care to fix that, too?