[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH for-2.8 0/2] pass partial discard requests all t
|
From: |
Eric Blake |
|
Subject: |
Re: [Qemu-devel] [PATCH for-2.8 0/2] pass partial discard requests all the way down |
|
Date: |
Fri, 11 Nov 2016 08:15:52 -0600 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 |
On 11/11/2016 04:11 AM, Laszlo Ersek wrote:
> On 11/11/16 11:09, Laszlo Ersek wrote:
>> On 11/11/16 00:10, Eric Blake wrote:
>>> Peter reported a mild regression in qemu 2.7 when targetting the
>>> Dell Equallogic iSCSI, which advertizes a preferred and maximum
>>> unmap alignment at 15M. In qemu 2.6, trims not aligned to those
>>> boundaries still made it to the device, but in 2.7, the block
>>> layer is ignoring unaligned portions of guest requests, resulting
>>> in fewer blocks being actually trimmed.
>>>
>>> Since discard is advisary,
>>
>> advisory?
>
> Ehh, sorry, I missed that this msg wouldn't be committed; it's just the
> blurb for the series. The actual commits and the code have the right
> spelling. Not gratuitously trying to be a smart-ass...
On the other hand, it's not every day you get to call me out on a typo,
so have fun doing it :)
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature