Re: [Qemu-devel] [PATCH v2 0/4] ppc/pnv: XSCOM fixes and unit tests

[no-reply]

Hi,

Your series seems to have some coding style problems. See output below for
more information:

Type: series
Subject: [Qemu-devel] [PATCH v2 0/4]  ppc/pnv: XSCOM fixes and unit tests
Message-id: address@hidden

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

# Useful git options
git config --local diff.renamelimit 0
git config --local diff.renames True

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git show --no-patch --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 * [new tag]         patchew/address@hidden -> patchew/address@hidden
Switched to a new branch 'test'
d3d45dc tests: add XSCOM tests for the PowerNV machine
495b638 ppc/pnv: Fix fatal bug on 32-bit hosts
662eee5 ppc/pnv: fix xscom address translation for POWER9
1a6e1d7 ppc/pnv: add a 'xscom_core_base' field to PnvChipClass

=== OUTPUT BEGIN ===
fatal: unrecognized argument: --no-patch
Checking PATCH 1/4: ...
fatal: unrecognized argument: --no-patch
Checking PATCH 2/4: ...
fatal: unrecognized argument: --no-patch
Checking PATCH 3/4: ...
fatal: unrecognized argument: --no-patch
Checking PATCH 4/4: ...
ERROR: suspect code indent for conditional statements (4, 9)
#92: FILE: tests/pnv-xscom-test.c:58:
+    if (chip->chip_type == PNV_CHIP_POWER9) {
+         addr |= ((uint64_t) pcba << 3);

total: 1 errors, 0 warnings, 147 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden