[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] mttcg: Move tb lock asserts under DEBUG_LOCKING
|
From: |
Pranith Kumar |
|
Subject: |
Re: [Qemu-devel] [PATCH] mttcg: Move tb lock asserts under DEBUG_LOCKING |
|
Date: |
Tue, 15 Nov 2016 10:10:16 -0500 |
On Tue, Nov 15, 2016 at 2:48 AM, Richard Henderson <address@hidden> wrote:
> On 11/15/2016 06:41 AM, Pranith Kumar wrote:
>>
>> Move the asserts in tb_lock/unlock() to DEBUG_LOCKING to avoid the
>> assert checking overhead in normal builds.
>
>
> I know DEBUG_LOCKING already exists in translate-all.c, but I think both
> this and the old ought to be using CONFIG_DEBUG_TCG, so that it is regularly
> enabled.
>
> At which point you might as well use tcg_debug_assert instead of these
> wrappers around g_assert.
>
Yes, that sounds more reasonable. I will work up a patch.
Thanks,
--
Pranith