[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v12 11/22] vfio iommu: Add blocking notifier to
From: |
Kirti Wankhede |
Subject: |
Re: [Qemu-devel] [PATCH v12 11/22] vfio iommu: Add blocking notifier to notify DMA_UNMAP |
Date: |
Tue, 15 Nov 2016 20:41:26 +0530 |
>> @@ -854,15 +857,29 @@ static int vfio_dma_do_unmap(struct vfio_iommu *iommu,
>> if (dma->task->mm != current->mm)
>> break;
>> unmapped += dma->size;
>> +
>> + mutex_unlock(&iommu->lock);
>> + if (iommu->external_domain && !RB_EMPTY_ROOT(&dma->pfn_list)) {
>> + struct vfio_iommu_type1_dma_unmap nb_unmap;
>> +
>> + nb_unmap.iova = dma->iova;
>> + nb_unmap.size = dma->size;
>> + blocking_notifier_call_chain(&iommu->notifier,
>> + VFIO_IOMMU_NOTIFY_DMA_UNMAP,
>> + &nb_unmap);
>> +
>> + if (WARN_ON(!RB_EMPTY_ROOT(&dma->pfn_list)))
>> + goto unmap_exit;
>> + }
>> + mutex_lock(&iommu->lock);
>
> Why are the mutexes pushed out so far, we are referencing way too much
> stuff outside of the mutex here. The notifier head has its own
> semaphore, so we should be able to squeeze the mutex opening to just
> around the notifier call, in which case we only worry about the iommu
> itself going way.
>
Right. Updating.
Thanks,
Kirti
- [Qemu-devel] [PATCH v12 06/22] vfio iommu type1: Update arguments of vfio_lock_acct, (continued)
- [Qemu-devel] [PATCH v12 06/22] vfio iommu type1: Update arguments of vfio_lock_acct, Kirti Wankhede, 2016/11/14
- [Qemu-devel] [PATCH v12 07/22] vfio iommu type1: Update argument of vaddr_get_pfn(), Kirti Wankhede, 2016/11/14
- [Qemu-devel] [PATCH v12 08/22] vfio iommu type1: Add find_iommu_group() function, Kirti Wankhede, 2016/11/14
- [Qemu-devel] [PATCH v12 09/22] vfio iommu type1: Add task structure to vfio_dma, Kirti Wankhede, 2016/11/14
- [Qemu-devel] [PATCH v12 10/22] vfio iommu type1: Add support for mediated devices, Kirti Wankhede, 2016/11/14
- [Qemu-devel] [PATCH v12 11/22] vfio iommu: Add blocking notifier to notify DMA_UNMAP, Kirti Wankhede, 2016/11/14
- [Qemu-devel] [PATCH v12 12/22] vfio: Add notifier callback to parent's ops structure of mdev, Kirti Wankhede, 2016/11/14
[Qemu-devel] [PATCH v12 13/22] vfio: Introduce common function to add capabilities, Kirti Wankhede, 2016/11/14
[Qemu-devel] [PATCH v12 14/22] vfio_pci: Update vfio_pci to use vfio_info_add_capability(), Kirti Wankhede, 2016/11/14
[Qemu-devel] [PATCH v12 15/22] vfio: Introduce vfio_set_irqs_validate_and_prepare(), Kirti Wankhede, 2016/11/14
[Qemu-devel] [PATCH v12 16/22] vfio_pci: Updated to use vfio_set_irqs_validate_and_prepare(), Kirti Wankhede, 2016/11/14